CLN: _wrap_applied_output #36160
Merged
CLN: _wrap_applied_output #36160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is unrelated. |
|
thanks @rhshadrach wouldn't be averse to simplifying this function even more with have some helper functions (and would location them in another module if possible as free functions and just passing in what you need), rather than locating them on the groupby objects themselves (e.g. to make this even easier to follow the cases) |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAll if statements above the changed block return, so we can remove the else's and flatten out the structure a bit.