-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
API: Make ExtensionDtype.construct_array_type a method #36136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,13 @@ Other enhancements | |
- | ||
- | ||
|
||
.. _whatsnew_120.api_breaking.experimental: | ||
|
||
Changes to experimental APIs | ||
---------------------------- | ||
|
||
- :meth:`pandas.api.extensions.ExtensionDtype.construct_array_type` has changed from a classmethod to a regular method to support one dtype being used for multiple arrays. To migrate, change your definition to a regular method and ensure that your method is called on instances rather than the class (:issue:`36126`). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be clear, as long as you are not calling it yourself on the class object, and only implementing it, it shouldn't directly break existing dtypes ? (a class method can also be called from an instance) (otherwise I think we should do it in a non-breaking way, eg by taking a different name) |
||
|
||
.. _whatsnew_120.api_breaking.python: | ||
|
||
Increased minimum version for Python | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it needs
~~~~~~~~~~~~~~~~~~~~~~~~
type header