Skip to content

REGR: ensure closed attribute of IntervalIndex is preserved in pickle roundtrip #36118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Closes #35658

cc @jbrockmendel

(I suppose the long term way would rather to properly pickle the IntervalArray itself and restore from that, instead of restoring from the left/right arrays, but would rather leave such a change for 1.2)

@jorisvandenbossche jorisvandenbossche added Regression Functionality that used to work in a prior pandas version Interval Interval data type IO Pickle read_pickle, to_pickle labels Sep 4, 2020
@jreback jreback added this to the 1.1.2 milestone Sep 4, 2020
@jreback jreback merged commit 9ad6363 into pandas-dev:master Sep 4, 2020
@jreback
Copy link
Contributor

jreback commented Sep 4, 2020

thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the regr-intervalindex-pickle-closed branch September 4, 2020 15:37
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 4, 2020
simonjayhawkins pushed a commit that referenced this pull request Sep 4, 2020
… preserved in pickle roundtrip (#36119)

Co-authored-by: Joris Van den Bossche <[email protected]>
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type IO Pickle read_pickle, to_pickle Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: IntervalIndex cannot be round-tripped pickled
3 participants