-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REGR: fix consolidation/cache issue with take operation #36114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 3 commits into
pandas-dev:master
from
jorisvandenbossche:regr-take-consolidate
Sep 4, 2020
Merged
REGR: fix consolidation/cache issue with take operation #36114
jreback
merged 3 commits into
pandas-dev:master
from
jorisvandenbossche:regr-take-consolidate
Sep 4, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm minor comments
The non-copying alternative would be to not call |
LGTM; can look into the no-copy solution longer-term |
jreback
approved these changes
Sep 4, 2020
thanks! |
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 5, 2020
…h take operation
jorisvandenbossche
added a commit
that referenced
this pull request
Sep 5, 2020
…ration (#36135) Co-authored-by: Joris Van den Bossche <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Indexing
Related to indexing on series/frames, not to indexes themselves
Regression
Functionality that used to work in a prior pandas version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35521
@jbrockmendel the "short term" fix for 1.1.2