Skip to content

BUG: add py39 compat check for ast.slice #32766 #36080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2020
Merged

BUG: add py39 compat check for ast.slice #32766 #36080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21af1c9
BUG: remvoe ast.slice #32766
fangchenli Sep 2, 2020
77d5aa1
BUG: add compat check #32766
fangchenli Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pandas/core/computation/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

import numpy as np

from pandas.compat import PY39

import pandas.core.common as com
from pandas.core.computation.ops import (
_LOCAL_TAG,
Expand Down Expand Up @@ -186,7 +188,6 @@ def _filter_nodes(superclass, all_nodes=_all_nodes):
_stmt_nodes = _filter_nodes(ast.stmt)
_expr_nodes = _filter_nodes(ast.expr)
_expr_context_nodes = _filter_nodes(ast.expr_context)
_slice_nodes = _filter_nodes(ast.slice)
_boolop_nodes = _filter_nodes(ast.boolop)
_operator_nodes = _filter_nodes(ast.operator)
_unary_op_nodes = _filter_nodes(ast.unaryop)
Expand All @@ -197,6 +198,9 @@ def _filter_nodes(superclass, all_nodes=_all_nodes):
_keyword_nodes = _filter_nodes(ast.keyword)
_alias_nodes = _filter_nodes(ast.alias)

if not PY39:
_slice_nodes = _filter_nodes(ast.slice)


# nodes that we don't support directly but are needed for parsing
_hacked_nodes = frozenset(["Assign", "Module", "Expr"])
Expand Down