Skip to content

CLN: _wrap_applied_output #36053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

2nd step toward #35412. In this, the order of the largest if-else is switched with the condition negated. We can then drop the else entirely, resulting in much of the function having one less level of nesting.

@pep8speaks
Copy link

pep8speaks commented Sep 1, 2020

Hello @rhshadrach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-01 22:06:57 UTC

@rhshadrach rhshadrach changed the title Wrap apply cleanup 2 CLN: Wrap apply cleanup 2 Sep 1, 2020
@rhshadrach rhshadrach changed the title CLN: Wrap apply cleanup 2 CLN: _wrap_applied_output Sep 1, 2020
@rhshadrach rhshadrach added Apply Apply, Aggregate, Transform, Map Clean Groupby labels Sep 1, 2020
@rhshadrach rhshadrach added this to the 1.2 milestone Sep 1, 2020
@jreback jreback merged commit 2a624dc into pandas-dev:master Sep 1, 2020
@jreback
Copy link
Contributor

jreback commented Sep 1, 2020

nice!

@rhshadrach rhshadrach deleted the _wrap_apply_cleanup_2 branch September 1, 2020 23:56
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Clean Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants