Skip to content

DOC: add semicolons to suppress text repr of matplotlib objects in visualization.rst #36043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

partev
Copy link
Contributor

@partev partev commented Sep 1, 2020

add semicolons (";") after the plotting function to suppress unnecessary debug messages similar to:

<matplotlib.axes._subplots.AxesSubplot at 0x7fe278bb5160>

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

add semicolons (";") after the plotting function to suppress unnecessary debug messages similar to:

<matplotlib.axes._subplots.AxesSubplot at 0x7fe278bb5160>
@WillAyd
Copy link
Member

WillAyd commented Sep 1, 2020

Is there a more generic way to do this? I think this is distracting for end users

@jorisvandenbossche

@WillAyd WillAyd added the Docs label Sep 1, 2020
@MarcoGorelli
Copy link
Member

I think this is distracting for end users

FWIW, I've seen this quite frequently in tutorials

@jorisvandenbossche jorisvandenbossche changed the title Update visualization.rst DOC: add semicolons to suppress text repr of matplotlib objects in visualization.rst Sep 1, 2020
@jorisvandenbossche
Copy link
Member

We indeed already do it in several places in visualization.rst itself (see https://pandas.pydata.org/docs/dev/user_guide/visualization.html), so this is making it more consistent.

@@ -286,10 +286,10 @@ subplots:

.. ipython:: python

plt.figure()
plt.figure();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this plt.figure() actually needed?

@jreback jreback added this to the 1.2 milestone Sep 5, 2020
@jreback jreback added the Visualization plotting label Sep 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 6, 2020
@jreback
Copy link
Contributor

jreback commented Oct 6, 2020

@partev can you merge master and we can get this in

@partev
Copy link
Contributor Author

partev commented Oct 7, 2020

@jreback done

@jreback jreback merged commit 0bdff60 into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks @partev

@jorisvandenbossche has a comment from above if you can have a look

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@partev partev deleted the patch-1 branch July 15, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants