-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
Categorical cleanup #3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categorical cleanup #3603
Conversation
Added a describe method as well. |
looks good to me, marked for 0.11.1 |
To be consistent (and not have the deprecate warnings internally), a couple of minor changes
|
Should I just change everything to Categorical? My reasoning for the deprecation is that Factor conflicts with the use of the term in patsy where a factor is not a "factor" in the R sense. I believe @wesm and @njsmith decided that Categorical was unambiguous and preferred, and I tend to agree but don't have a really strong feeling about this. |
I say yes (its not much to change), leave in |
Ok, should be better. No deprecation warnings internally now, though I left the term factor in a few places where it's clear from context what it's referring to (I think). |
@jseabold can you add a release notes & v0.11.1 mention? |
thank you sir! |
Make categorical a little more user-friendly and add some documentation.