Skip to content

remove trailing commas for #35925 #36029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2020
Merged

remove trailing commas for #35925 #36029

merged 3 commits into from
Sep 1, 2020

Conversation

Anshoo-Rajput
Copy link
Contributor

@Anshoo-Rajput Anshoo-Rajput commented Sep 1, 2020 •
edited
Loading

  • pandas/io/parquet.py
  • pandas/io/parsers.py
  • pandas/io/pytables.py

@Anshoo-Rajput Anshoo-Rajput changed the title remove trailing commas remove trailing commas for #35925 Sep 1, 2020
@Anshoo-Rajput
Copy link
Contributor Author

xref #35925

@simonjayhawkins
Copy link
Member

Thanks @rajanshoo25 for the PR. generally lgtm.

@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks labels Sep 1, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Sep 1, 2020
@simonjayhawkins
Copy link
Member

@rajanshoo25 CI / Checks (pull_request) failing. need to run black again after the changes

black, version 19.10b0
Checking black formatting
would reformat /home/runner/work/pandas/pandas/pandas/io/parsers.py
Oh no! 💥 💔 💥
1 file would be reformatted, 1122 files would be left unchanged.

MarcoGorelli
MarcoGorelli approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@simonjayhawkins simonjayhawkins merged commit 329e1c7 into pandas-dev:master Sep 1, 2020
@simonjayhawkins
Copy link
Member

Thanks @rajanshoo25

@Anshoo-Rajput
Copy link
Contributor Author

Thanks @rajanshoo25

Thanks a lot! @simonjayhawkins for guiding me. Actually I am new in open-source contribution.

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@Anshoo-Rajput
remove trailing commas for pandas-dev#35925 (pandas-dev#36029)
b1969e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Anshoo-Rajput @simonjayhawkins @MarcoGorelli