TYP: Annotate plotting stacker #36016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +154,7 @@ def _make_plot(self): | |||
| labels = [pprint_thing(key) for key in range(len(labels))] | |||
| self._set_ticklabels(ax, labels) | |||
|
|
|||
| def _set_ticklabels(self, ax, labels): | |||
| def _set_ticklabels(self, ax: "Axes", labels): | |||
There was a problem hiding this comment.
I've opened #36034 so that when reviewing we can just click on and get definition as doesn't work for string literals (in VS Code anyway)
pandas/plotting/_matplotlib/core.py
Outdated
| @@ -667,10 +665,10 @@ def _plot(cls, ax, x, y, style=None, is_errorbar=False, **kwds): | |||
| if style is not None: | |||
| args = (x, y, style) | |||
| else: | |||
| args = (x, y) | |||
| args = (x, y) # type:ignore | |||
There was a problem hiding this comment.
if adding ignores can you add the mypy error code and the mypy error message as a comment.
In this case, it's a relative simple cleanup. add a variable type declaration for args?
| @@ -916,15 +914,15 @@ def __init__(self, data, x, y, **kwargs): | |||
| self.y = y | |||
|
|
|||
| @property | |||
| def nseries(self): | |||
| def nseries(self) -> int: | |||
There was a problem hiding this comment.
possibly a use of Literal after vendoring PR merged
…notate-plotting-stacker
simonjayhawkins
approved these changes
Sep 1, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
yea also lgtm test failures seems unrelated so restarted. merge on green |
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In AreaPlot._plot we call
ax.fill_between, which meansaxmust be anAxesobject (and in particular, not anAxisobject). This chases down all the other places we can inferAxesfrom that.Then some edits in an
__init__to get mypy passing, and revert annotations of_plotin a few places because mypy complained about signature mismatch.