TYP: misc typing cleanup in core/indexes/multi.py #36007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/indexes/multi.py
Outdated
| @@ -2435,7 +2453,7 @@ def _get_partial_string_timestamp_match_key(self, key): | |||
| if isinstance(key, str) and self.levels[0]._supports_partial_string_indexing: | |||
| # Convert key '2016-01-01' to | |||
| # ('2016-01-01'[, slice(None, None, None)]+) | |||
| key = tuple([key] + [slice(None)] * (len(self.levels) - 1)) | |||
| key = tuple((key, *([slice(None)] * (len(self.levels) - 1)))) | |||
There was a problem hiding this comment.
i find this less clear than the status quo. what about (key,) + (slice(None),) * num?
There was a problem hiding this comment.
Yea I agree here; if there's a way to do this without unpacking would read a lot more clearly
Alternately can be split into separate lines
|
thanks @simonjayhawkins |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* TYP: misc typing cleanup in core/indexes/multi.py * update per comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas\core\indexes\multi.py:496: error: Need type annotation for 'arrays' [var-annotated]
pandas\core\indexes\multi.py:722: error: Incompatible types in assignment (expression has type "List[Any]", variable has type "FrozenList") [assignment]
pandas\core\indexes\multi.py:893: error: Incompatible types in assignment (expression has type "List[Any]", variable has type "FrozenList") [assignment]
pandas\core\indexes\multi.py:2438: error: List item 0 has incompatible type "slice"; expected "str" [list-item]
pandas\core\indexes\multi.py:3095: error: Unsupported left operand type for | ("None") [operator]