Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Can't restore index from parquet with offset-specified timezone #35997 #36004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Can't restore index from parquet with offset-specified timezone #35997 #36004
Changes from all commits
1772840
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this so that on future versions of pyarrow it will set check_dtype=True (IOW when the bug is fixed). otherwise I am worried this will perpetuate forever.
alternatively, could remove the check_dtype and just xfail this (and when new pyarrow fixes this test will then start to xpass which will make it fail as we have strict=True). so again could make this a conditional on an older / newer version of pyarrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback based on the comment above by @jorisvandenbossche , I don't expect this to be "fixed" in Arrow.
pytz.FixedOffset
is a wrapper aroundtimedelta
likedatetime.timezone
is and they both implementdatetime.tzinfo
. ofc I'm happy to do any change you askThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are no active plans in pyarrow to change this. Although it makes probably sense to use
datetime.timezone
, but if we do that, it'spytz.FixedOffset
that won't be preserved, in which case another test probably needs acheck_dtype=False
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback I added a long description. I know this won't help a follow up improvement in the future, but at this point it's unlikely to change.
There are two scenarios:
check_timezone_dtype=False
by default) acceptingpytz.FixedOffset
anddatetime.timezone
equalityI don't see any of them on the short or mid-term roadmap.