-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Add Notes about difference to numpy behaviour for ddof in std() GH35985 #35986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add Notes about difference to numpy behaviour for ddof in std() GH35985 #35986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timhunderwood, small suggested wording edit
wording change. Co-authored-by: Daniel Saxton <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @timhunderwood
normalizes by N
Are you sure this is correct? Does dividing by N actually normalise the quantity?
IMO it should be enough to write something like
Notes
-----
To have the same behaviour as `numpy.std`, use `ddof=0` (instead of the default `ddof=1`)
…b.com/timhunderwood/pandas into feature/doc-std-clarification-GH35985 � Conflicts: � pandas/core/generic.py
thanks @MarcoGorelli , I agree this could be confusing. I've changed to your simpler wording, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an improvement to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, can you fetch and merge upstream/master and then push again to restart the CI process in order to get it green?
…ature/doc-std-clarification-GH35985
Done - CI process has started... |
Thanks @timhunderwood ! |
…GH35985 (pandas-dev#35986) * DOC: Add Notes about difference to numpy behaviour for ddof. GH35985. * remove trailing whitespace. * Update pandas/core/generic.py wording change. Co-authored-by: Daniel Saxton <[email protected]> * Make wording simpler and remove reference to normalization. * Make wording simpler and remove reference to normalization. Co-authored-by: Daniel Saxton <[email protected]>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff