CLN: window/rolling.py #35982
Merged
CLN: window/rolling.py #35982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Aug 30, 2020
pandas/core/window/rolling.py
Outdated
|
|
||
| return type(obj)(result, index=index, columns=block.columns) | ||
| return result | ||
| return Series(result, obj.index, name=obj.name) |
|
Thanks @mroeschke |
| @@ -454,7 +444,7 @@ def _insert_on_column(self, result: "DataFrame", obj: "DataFrame"): | |||
| # insert at the end | |||
| result[name] = extra_col | |||
|
|
|||
| def _center_window(self, result, window) -> np.ndarray: | |||
| def _center_window(self, result: np.ndarray, window) -> np.ndarray: | |||
There was a problem hiding this comment.
ATM _prep_values prevents us from doing anything with EAs, but in principle is that something we'd like to support?
There was a problem hiding this comment.
In the future yes, but I think a major blocker/consideration is that today rolling agg functions only operate on float64 inputs, so that will need to be addressed in tandem.
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Aug 31, 2020
* CLN: rolling.py * Use obj._constructor instead Co-authored-by: Matt Roeschke <[email protected]>
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* CLN: rolling.py * Use obj._constructor instead Co-authored-by: Matt Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff