-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Optimize nrows in read_excel #35974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WillAyd
merged 97 commits into
pandas-dev:master
from
MarcoGorelli:optimise-nrows-excel
Sep 21, 2020
Merged
Changes from all commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
900afff
ENH: Skip rows while reading excel file with engine=openpyxl
mproszewska df55b51
ENH: Skiping rows with odf engine
mproszewska 8177024
ENH: Optimize nrows in read_excel
mproszewska 79b34c3
Reformatted
mproszewska f0a2b8d
Fix linting
mproszewska 70ac234
Add annotation to variable
mproszewska 27cae3a
Add imports
mproszewska 4248f8c
Add types
mproszewska 70f46b3
ENH: Fix
mproszewska cdfc05d
ENH: Mark variables as optional
mproszewska 502b5e3
Merge branch 'master' into excel
mproszewska 4c8a42a
ENH: Move nrows variable check
mproszewska 19bb927
ENH: Remove unused imports
mproszewska 6c2a3b5
ENH: Move repeated code to base
mproszewska b865c88
ENH: Remove import
mproszewska 49276da
ENH: Lint
mproszewska 393a622
ENH: Lint
mproszewska e00fff1
ENH: Add docstring to should_read_row
mproszewska b14642b
ENH: Lint
mproszewska dfc794a
ENH: Lint
mproszewska 7b501de
ENH: Move nrows value check
mproszewska 3292f6b
ENH: Remove nrows validation
mproszewska bdd5780
Run tests
mproszewska 1867088
ENH: Fix reading rows in openpyxl
mproszewska 3c1eb10
ENH: Fix lint
mproszewska 88c3117
Fix max_row variable definition
mproszewska dc60055
Fix max_row variable definition
mproszewska 6fdedfd
Add typed in should_read_row function
mproszewska ba7175c
Add types and tests
mproszewska d884803
Add whatsnew
mproszewska 368544a
Resolve conflict
mproszewska 4be3d27
Fix import
mproszewska 95e3e02
Update doc/source/whatsnew/v1.1.0.rst
mproszewska 38520e2
Add index type
mproszewska 0b21e61
Merge branch 'excel' of https://github.com/mproszewska/pandas into excel
mproszewska c03b46a
Parametrize test
mproszewska aa8cfe9
Fix lint
mproszewska c9a622d
Add decorator to test
mproszewska aa92783
Fix types defintion
mproszewska ee16c15
Change function name
mproszewska 547787a
Leaks in test fix attempt
mproszewska 368b77c
Reverse changes
mproszewska 4d69922
Change skiping rows in openpyxl
mproszewska b4ae85f
Run tests again
mproszewska 81f8674
Remove all changes in openpyxl because of leaks
mproszewska 7938fcf
Run tests
mproszewska 7f31a30
Fix
mproszewska ae8b84f
Add types
mproszewska a4f5009
Run tests
mproszewska d7a2892
Run tests again because of conda error
mproszewska c94b45e
PERF: Remove unnecessary copies in sorting functions
mproszewska 0ab450b
Run tests
mproszewska 54c7304
Run tests
mproszewska ca388dc
Merge branch 'master' into excel
mproszewska 9ddc41c
Resolve conflicts
mproszewska 1920905
Resolve conflicts
mproszewska 6d72a34
Add asv
mproszewska 5ba54a6
Run black
mproszewska 2766270
Remove asv
mproszewska 91176ca
Merge branch 'perf'
mproszewska f748b78
Merge remote-tracking branch 'upstream/master'
mproszewska ac823f5
Resolve conflict
mproszewska f4a805d
Resolve conflict
mproszewska 6f188fe
Revert change
mproszewska ba314fe
Change should_skip_row function
mproszewska f923bfd
Fix return type
mproszewska 008add5
Remove import
mproszewska c04c494
Merge remote-tracking branch 'upstream/master'
mproszewska 596806c
Resolve conflict
mproszewska 2226050
Run tests
mproszewska 9216210
Add asv
mproszewska d9aa319
Add asv
mproszewska 094d5f7
Merge branch 'master' into excel
mproszewska 234dcc6
Resolve conflict
mproszewska 0afb1b1
Fix
mproszewska 33cb733
Merge branch 'master' into excel
mproszewska 06003a8
Fix asv
mproszewska c08709b
Fix asv
mproszewska c9a2c75
Fix asv
mproszewska 4e5d048
Merge commit 'refs/pull/33281/head' of github.com:pandas-dev/pandas i…
MarcoGorelli a0c0111
merge conflict
MarcoGorelli a2531c0
:art:
MarcoGorelli 2ce28c2
:art:
MarcoGorelli 6979ae6
:art:
MarcoGorelli 8d2dd01
:truck:
MarcoGorelli d4720bb
:art:
MarcoGorelli d0a8a68
:pencil:
MarcoGorelli 8f6ead4
Merge remote-tracking branch 'upstream/master' into optimise-nrows-excel
MarcoGorelli 98e4093
simplify
MarcoGorelli b49e8a9
optimise other readers too
MarcoGorelli 04ed5e8
type
MarcoGorelli 0eb3200
expand test
MarcoGorelli e88fe1e
move whatsnew note
MarcoGorelli 28e51e6
skip pyxl
MarcoGorelli 2d9ee8d
Merge remote-tracking branch 'upstream/master' into optimise-nrows-excel
MarcoGorelli bdb5630
Merge remote-tracking branch 'upstream/master' into optimise-nrows-excel
MarcoGorelli b242ca3
Merge branch 'master' into optimise-nrows-excel
jreback File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like its causing failures on master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=43000&view=logs&j=b1c7b65e-b3ce-541a-7fd5-29b4ba56ce18&t=46ecc253-e38f-5abc-2ea7-addca6b44d0a
@jbrockmendel can you revert for now and we can reopen