Skip to content

Comma cleanup #35971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Comma cleanup #35971

wants to merge 6 commits into from

Conversation

JonathanShrek
Copy link
Contributor

Comma cleanup for #35925

@simonjayhawkins
Copy link
Member

Thanks @JonathanShrek for the PR. need to run black after removing commas to get CI / Checks (pull_request) to pass.

@simonjayhawkins simonjayhawkins added Clean Code Style Code style, linting, code_checks labels Aug 29, 2020
@JonathanShrek
Copy link
Contributor Author

Thanks @JonathanShrek for the PR. need to run black after removing commas to get CI / Checks (pull_request) to pass.

I've run 'black' on each file that I have changed and for some reason CI / Checks (pull_request) continues to fail. I'm just going to close the PR. Sorry for the inconvenience. I'm a first time contributor.

@MarcoGorelli
Copy link
Member

Thanks @JonathanShrek for the PR. need to run black after removing commas to get CI / Checks (pull_request) to pass.

I've run 'black' on each file that I have changed and for some reason CI / Checks (pull_request) continues to fail. I'm just going to close the PR. Sorry for the inconvenience. I'm a first time contributor.

No inconvenience caused - feel free to ask for help if you're stuck on something. This looks like it was on the right track, you just needed to remove the trailing commas and then run black again

@JonathanShrek
Copy link
Contributor Author

Thanks @MarcoGorelli I’ll give it another shot this afternoon.

@JonathanShrek JonathanShrek reopened this Sep 1, 2020
@pep8speaks
Copy link

Hello @JonathanShrek! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 115:1: E122 continuation line missing indentation or outdented
Line 115:3: E225 missing whitespace around operator
Line 115:5: E227 missing whitespace around bitwise or shift operator
Line 117:1: E122 continuation line missing indentation or outdented
Line 117:3: E225 missing whitespace around operator
Line 117:5: E225 missing whitespace around operator
Line 117:8: E251 unexpected spaces around keyword / parameter equals
Line 123:1: E122 continuation line missing indentation or outdented
Line 123:7: E225 missing whitespace around operator

Line 935:1: E122 continuation line missing indentation or outdented
Line 935:3: E225 missing whitespace around operator
Line 935:5: E227 missing whitespace around bitwise or shift operator
Line 937:1: E122 continuation line missing indentation or outdented
Line 937:3: E225 missing whitespace around operator
Line 937:5: E225 missing whitespace around operator
Line 937:8: E251 unexpected spaces around keyword / parameter equals
Line 941:1: E122 continuation line missing indentation or outdented
Line 941:7: E225 missing whitespace around operator

Line 812:1: E122 continuation line missing indentation or outdented
Line 812:3: E225 missing whitespace around operator
Line 812:5: E227 missing whitespace around bitwise or shift operator
Line 814:1: E122 continuation line missing indentation or outdented
Line 814:3: E225 missing whitespace around operator
Line 814:5: E225 missing whitespace around operator
Line 814:8: E251 unexpected spaces around keyword / parameter equals
Line 817:1: E122 continuation line missing indentation or outdented
Line 817:7: E225 missing whitespace around operator

Line 744:3: E227 missing whitespace around bitwise or shift operator
Line 744:7: E225 missing whitespace around operator
Line 745:1: E302 expected 2 blank lines, found 0
Line 746:3: E225 missing whitespace around operator
Line 746:5: E225 missing whitespace around operator
Line 746:7: E225 missing whitespace around operator
Line 751:7: E225 missing whitespace around operator

Line 60:1: E122 continuation line missing indentation or outdented
Line 60:3: E225 missing whitespace around operator
Line 60:5: E227 missing whitespace around bitwise or shift operator
Line 62:1: E122 continuation line missing indentation or outdented
Line 62:3: E225 missing whitespace around operator
Line 62:5: E225 missing whitespace around operator
Line 62:8: E251 unexpected spaces around keyword / parameter equals
Line 65:1: E122 continuation line missing indentation or outdented
Line 65:7: E225 missing whitespace around operator
Line 98:1: E122 continuation line missing indentation or outdented
Line 98:3: E225 missing whitespace around operator
Line 98:5: E227 missing whitespace around bitwise or shift operator
Line 100:1: E122 continuation line missing indentation or outdented
Line 100:3: E225 missing whitespace around operator
Line 100:5: E225 missing whitespace around operator
Line 100:8: E251 unexpected spaces around keyword / parameter equals
Line 103:1: E122 continuation line missing indentation or outdented
Line 103:7: E225 missing whitespace around operator
Line 134:1: E122 continuation line missing indentation or outdented
Line 134:3: E225 missing whitespace around operator
Line 134:5: E227 missing whitespace around bitwise or shift operator
Line 136:1: E122 continuation line missing indentation or outdented
Line 136:3: E225 missing whitespace around operator
Line 136:5: E225 missing whitespace around operator
Line 136:8: E251 unexpected spaces around keyword / parameter equals
Line 139:1: E122 continuation line missing indentation or outdented
Line 139:7: E225 missing whitespace around operator
Line 160:1: E122 continuation line missing indentation or outdented
Line 160:3: E225 missing whitespace around operator
Line 160:5: E227 missing whitespace around bitwise or shift operator
Line 162:1: E122 continuation line missing indentation or outdented
Line 162:3: E225 missing whitespace around operator
Line 162:5: E225 missing whitespace around operator
Line 162:8: E251 unexpected spaces around keyword / parameter equals
Line 165:1: E122 continuation line missing indentation or outdented
Line 165:7: E225 missing whitespace around operator

@JonathanShrek JonathanShrek deleted the commaCleanup branch September 1, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants