BUG: Fix DataFrame.groupby().apply() for NaN groups with dropna=False #35951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5889) * tests should still fail. * test dropna=True|False with no np.nan in groupings. * fix expected outputs, declare expected MultiIndex in resulting dataframe after df.group().apply()
* nans at same positions in `level` and `key` compares as equal.
* this makes test pass. * follow existing style where we create MultiIndex, then `set_levels` to reinsert nan for case when `dropna=False`, and groups has nan grouping.
* black pandas * git diff upstream/master -u -- "*.py" | flake8 --diff
arw2019
approved these changes
Aug 29, 2020
|
@cwkwong might want to have a more descriptive title |
cwkwong
changed the title
|
Thanks @arw2019 for approving the changes. What's the next step to hopefully make this as part of the |
charlesdong1991
suggested changes
Sep 1, 2020
There was a problem hiding this comment.
thanks for the PR @cwkwong
This should be moved to whatsnew 1.2.0 note. 1.1.2 mainly focuses on regression issue.
|
thanks @cwkwong very nice |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffv1.1.2.rst