REGR: DatetimeIndex.intersection incorrectly raising AssertionError #35877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I personally think it's fine to test / note only the root issue since the OP wasn't minimal (makes for cleaner / better tests IMO). Did a quick sanity check and this does fix the groupby issue also. |
jreback
added
Index
|
thanks @jbrockmendel and @dsaxton |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 24, 2020
…ectly raising AssertionError
jorisvandenbossche
pushed a commit
that referenced
this pull request
Aug 25, 2020
…ing AssertionError (#35879) Co-authored-by: jbrockmendel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@dsaxton this PR's test and whatsnew note reference the underlying issue you identified in #35876, but not the OP issue. Do you think we should add a test/note for that directly?