COMPAT: Ensure rolling indexers return intp during take operations #35875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Compat
pandas/core/window/indexers.py
Outdated
| @@ -298,7 +299,7 @@ def get_window_bounds( | |||
| window_indicies_start = 0 | |||
| for key, indicies in self.groupby_indicies.items(): | |||
| if self.index_array is not None: | |||
| index_array = self.index_array.take(indicies) | |||
| index_array = self.index_array.take(ensure_platform_int(indicies)) | |||
|
nice! |
TomAugspurger
approved these changes
Aug 24, 2020
added 2 commits
August 24, 2020 11:33
|
thanks @mroeschke |
Closed
|
This should backport automatically and fix the failing groupby 32bit tests #37466 (comment) after backporting this could also revert #36220 |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 28, 2020
…intp during take operations
simonjayhawkins
pushed a commit
that referenced
this pull request
Oct 28, 2020
…eturn intp during take operations) (#37471) Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffTested locally with @TomAugspurger docker container and the tests were working: #35228 (comment)