-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Bump asv Python version #35798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump asv Python version #35798
Conversation
If we change this, let's directly bump to Python 3.8? It has come up a few times before recently (updating the python version, eg #34699), and the conclusion was to do this after the 1.1 release, so now is the time ;) |
Yep, might as well do it now.
Though it would be good if anyone could scan through the recent values to
look for regressions, since that will become harder after the break.
…On Wed, Aug 19, 2020 at 1:57 AM Joris Van den Bossche < ***@***.***> wrote:
If we change this, let's directly bump to Python 3.8?
It has come up a few times before recently (updating the python version,
eg #34699 <#34699>), and the
conclusion was to do this after the 1.1 release, so now is the time ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35798 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIRPXXY5QGEHUXEHW7LSBNZWJANCNFSM4QEOMLVA>
.
|
Does this then close #34677? There's a comment there about things failing on Python 3.6 which seems not to be relevant anymore. |
Taking a quick look at the asv time series a few that jumped out to me: https://pandas.pydata.org/speed/pandas/#timeseries.TimeDatetimeConverter.time_convert Looks like the first two are somewhat recent regressions that may or may not already have issues (I think you reported a bunch of these recently @TomAugspurger), the other two go a bit further back. Edit: Seems Tom already has an issue open for reindexing, and the datetime converter one might be a necessary for matplotlib compatibility #35393? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Let's give this a shot. I'll hopefully have time to debug stuff in the next couple days if the benchmark machine doesn't pick this up automatically. |
Got this error trying to run the asvs locally and bumping the Python version in asv.conf.json fixed it:
Let me know if this is needed / correct in general or if it was just a thing with my machine.
cc @TomAugspurger
Closes #34677