Skip to content

Bump asv Python version #35798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Bump asv Python version #35798

merged 3 commits into from
Aug 26, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Aug 19, 2020

Got this error trying to run the asvs locally and bumping the Python version in asv.conf.json fixed it:

   STDOUT -------->
   Processing /Users/danielsaxton/pandas/asv_bench/env/a36d556a9d1611aba4092dc48036d261/project
       Preparing wheel metadata: started
       Preparing wheel metadata: finished with status 'done'
   STDERR -------->
   ERROR: Package 'pandas' requires a different Python: 3.6.10 not in '>=3.7.1'

Let me know if this is needed / correct in general or if it was just a thing with my machine.

cc @TomAugspurger

Closes #34677

@dsaxton dsaxton added the Benchmark Performance (ASV) benchmarks label Aug 19, 2020
@jorisvandenbossche
Copy link
Member

If we change this, let's directly bump to Python 3.8?

It has come up a few times before recently (updating the python version, eg #34699), and the conclusion was to do this after the 1.1 release, so now is the time ;)

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 19, 2020 via email

@dsaxton
Copy link
Member Author

dsaxton commented Aug 19, 2020

Does this then close #34677? There's a comment there about things failing on Python 3.6 which seems not to be relevant anymore.

@dsaxton
Copy link
Member Author

dsaxton commented Aug 19, 2020

Taking a quick look at the asv time series a few that jumped out to me:

https://pandas.pydata.org/speed/pandas/#timeseries.TimeDatetimeConverter.time_convert
https://pandas.pydata.org/speed/pandas/#reindex.LevelAlign.time_reindex_level
https://pandas.pydata.org/speed/pandas/#timedelta.TimedeltaIndexing.time_intersection
https://pandas.pydata.org/speed/pandas/#io.hdf.HDFStoreDataFrame.time_read_store_mixed

Looks like the first two are somewhat recent regressions that may or may not already have issues (I think you reported a bunch of these recently @TomAugspurger), the other two go a bit further back.

Edit: Seems Tom already has an issue open for reindexing, and the datetime converter one might be a necessary for matplotlib compatibility #35393?

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.2 milestone Aug 26, 2020
@TomAugspurger
Copy link
Contributor

Let's give this a shot. I'll hopefully have time to debug stuff in the next couple days if the benchmark machine doesn't pick this up automatically.

@TomAugspurger TomAugspurger merged commit d1e29be into pandas-dev:master Aug 26, 2020
@dsaxton dsaxton deleted the bump-asv-python-version branch August 26, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ASV Benchmarks failing to build
4 participants