-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: issubclass check with dtype instead of type, closes GH#24883 #35794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm, can you add a whatsnew note. |
updated+green |
milestone 1.2 whatsnew 1.1.2 do you want this backported? |
i think so yes |
@meeseeksdev backport 1.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
…d of type, closes GH#24883
… closes GH#24883 (#35919) Co-authored-by: jbrockmendel <[email protected]>
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff