-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: clean v1.1.1 release notes #35787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: clean v1.1.1 release notes #35787
Conversation
@TomAugspurger I don't think we need the subheaders for bugfixes in patch releases |
Looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a few comments on dysfunctional API links, but those can also be done as follow-up (since not strictly related to the changes you did)
doc/source/whatsnew/v1.1.1.rst
Outdated
@@ -15,20 +15,23 @@ including other versions of pandas. | |||
Fixed regressions | |||
~~~~~~~~~~~~~~~~~ | |||
|
|||
- Fixed regression in :meth:`CategoricalIndex.format` where, when stringified scalars had different lengths, the shorter string would be right-filled with spaces, so it had the same length as the longest string (:issue:`35439`) | |||
- Fixed regression in :meth:`Series.truncate` when trying to truncate a single-element series (:issue:`35544`) | |||
- Fixed regression where :meth:`DataFrame.to_numpy` would raise a ``RuntimeError`` for mixed dtypes when converting to ``str`` (:issue:`35455`) | |||
- Fixed regression where :func:`read_csv` would raise a ``ValueError`` when ``pandas.options.mode.use_inf_as_na`` was set to ``True`` (:issue:`35493`) | |||
- Fixed regression where :func:`pandas.testing.assert_series_equal` would raise an error when non-numeric dtypes were passed with ``check_exact=True`` (:issue:`35446`) | |||
- Fixed regression in :class:`pandas.core.groupby.RollingGroupby` where column selection was ignored (:issue:`35486`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RollingGroupby doesn't exist in our API docs, so doing "Fixed regression in .groupby(..).rolling(..)
" instead is probably better (it's done like that a few lines below as well)
doc/source/whatsnew/v1.1.1.rst
Outdated
- | ||
|
||
**Groupby/resample/rolling** | ||
|
||
- Bug in :class:`pandas.core.groupby.RollingGroupby` where passing ``closed`` with column selection would raise a ``ValueError`` (:issue:`35549`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here like above
Co-authored-by: Joris Van den Bossche <[email protected]>
Thanks @jorisvandenbossche I've also updated That should just leave and https://pandas.pydata.org/docs/dev/whatsnew/v1.1.1.html Could link to Index.format() instead and re-write note for context. |
Co-authored-by: Simon Hawkins <[email protected]>
No description provided.