Skip to content

REGR: follow-up to return copy with df.interpolate on empty DataFrame #35774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2020
Merged

REGR: follow-up to return copy with df.interpolate on empty DataFrame #35774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be769f2
REGR: follow-up to return copy with df.interpolate on empty DataFrame
simonjayhawkins Aug 17, 2020
f7b642c
Merge remote-tracking branch 'upstream/master' into followup
simonjayhawkins Aug 18, 2020
6fefb5b
assert result is not df
simonjayhawkins Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6893,7 +6893,7 @@ def interpolate(
obj = self.T if should_transpose else self

if obj.empty:
return self
return self.copy()

if method not in fillna_methods:
axis = self._info_axis_number
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/frame/methods/test_interpolate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def test_interp_empty(self):
# https://github.com/pandas-dev/pandas/issues/35598
df = DataFrame()
result = df.interpolate()
assert result is not df
expected = df
tm.assert_frame_equal(result, expected)

Expand Down