-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Unpin Pytest + Pytest Asyncio Min Version #35757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pytest 5.4.0 Released: Mar 12, 2020 this is a bit recent to requires as minimum version. but
if we have a minimum version of pytest-asyncio>=0.12.0 then a minimum version of pytest>=5.0.1 this would be inconsistent does conda not resolve these inconsistencies? |
Yep looks like conda solver handles this, in 38 locale build logs below So I think we can keep pytest min version as you suggested :)
|
thanks @alimcmaster1 @simonjayhawkins didn't backport to 1.1.1 |
ok won't do it now, but will backport after 1.1.1 so marking as still needs manual backport |
thanks both - I can backport this post 1.1.1 Ali |
@meeseeksdev backport 1.1.x |
…5833) Co-authored-by: Ali McMaster <[email protected]>
Debian currently has incompatible versions of pytest_asyncio and pytest, causing these tests to error on collection. Author: Rebecca N. Palmer <[email protected]> Bug-Debian: https://bugs.debian.org/969050 Forwarded: not-needed pandas-dev/pandas#35757 Gbp-Pq: Name disable_pytest_asyncio.patch
Pytest 6.0.0+ will require pytest-asyncio>=0.12.0 for these async tests to run.
Also worth noting
pytest-asyncio 0.12.0 requires pytest>=5.4.0
. (So maybe we should think about bumping min pytest version)cc @simonjayhawkins