Skip to content

CI: Unpin Pytest + Pytest Asyncio Min Version #35757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

alimcmaster1
Copy link
Member

Pytest 6.0.0+ will require pytest-asyncio>=0.12.0 for these async tests to run.

Also worth noting pytest-asyncio 0.12.0 requires pytest>=5.4.0. (So maybe we should think about bumping min pytest version)

____________________________________________________________________________________ ERROR collecting pandas/tests/indexes/test_base.py _____________________________________________________________________________________
../../.conda/envs/pandas-dev/lib/python3.8/site-packages/pluggy/hooks.py:286: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
../../.conda/envs/pandas-dev/lib/python3.8/site-packages/pluggy/manager.py:93: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
../../.conda/envs/pandas-dev/lib/python3.8/site-packages/pluggy/manager.py:84: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
../../.conda/envs/pandas-dev/lib/python3.8/site-packages/pytest_asyncio/plugin.py:39: in pytest_pycollect_makeitem
    item = pytest.Function(name, parent=collector)
../../.conda/envs/pandas-dev/lib/python3.8/site-packages/_pytest/nodes.py:95: in __call__
    warnings.warn(NODE_USE_FROM_PARENT.format(name=self.__name__), stacklevel=2)
E   pytest.PytestDeprecationWarning: Direct construction of Function has been deprecated, please use Function.from_parent.
E   See https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent for more details.

cc @simonjayhawkins

@simonjayhawkins
Copy link
Member

Also worth noting pytest-asyncio 0.12.0 requires pytest>=5.4.0. (So maybe we should think about bumping min pytest version)

pytest 5.4.0 Released: Mar 12, 2020

this is a bit recent to requires as minimum version.

but

Pytest 6.0.0+ will require pytest-asyncio>=0.12.0 for these async tests to run.

if we have a minimum version of pytest-asyncio>=0.12.0 then a minimum version of pytest>=5.0.1 this would be inconsistent

does conda not resolve these inconsistencies?

@simonjayhawkins simonjayhawkins added CI Continuous Integration Testing pandas testing functions or related to the test suite labels Aug 17, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 17, 2020
@alimcmaster1
Copy link
Member Author

Yep looks like conda solver handles this, in 38 locale build logs below

So I think we can keep pytest min version as you suggested :)

pytest                    6.0.1            py38h32f6830_0    conda-forge
pytest-asyncio            0.12.0           py38h32f6830_1    conda-forge
pytest-azurepipelines     0.8.0                      py_0    conda-forge
pytest-forked             1.2.0              pyh9f0ad1d_0    conda-forge
pytest-xdist              2.0.0                      py_0    conda-forge

@alimcmaster1 alimcmaster1 changed the title CI: Pytest Asyncio Min Version CI: Unpin Pytest + Pytest Asyncio Min Version Aug 19, 2020
@jreback jreback merged commit bdc7bb1 into pandas-dev:master Aug 19, 2020
@jreback
Copy link
Contributor

jreback commented Aug 19, 2020

thanks @alimcmaster1

@simonjayhawkins didn't backport to 1.1.1

@simonjayhawkins
Copy link
Member

ok won't do it now, but will backport after 1.1.1 so marking as still needs manual backport

@alimcmaster1
Copy link
Member Author

thanks both - I can backport this post 1.1.1

Ali

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 20, 2020
simonjayhawkins pushed a commit that referenced this pull request Aug 21, 2020
raspbian-autopush pushed a commit to raspbian-packages/pandas that referenced this pull request Aug 31, 2020
Debian currently has incompatible versions of pytest_asyncio and
pytest, causing these tests to error on collection.

Author: Rebecca N. Palmer <[email protected]>
Bug-Debian: https://bugs.debian.org/969050
Forwarded: not-needed pandas-dev/pandas#35757


Gbp-Pq: Name disable_pytest_asyncio.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Linux py36_locale failures with pytest DeprecationWarning
3 participants