Pass check_dtype to assert_extension_array_equal #35750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Bug
ExtensionArray
|
i've milestoned this 1.1.1. It does not appear to be a regression but no harm in backporting this. can put in bugfix section of whatsnew |
dsaxton
commented
Aug 16, 2020
| left._values, right._values, index_values=np.asarray(left.index) | ||
| left._values, | ||
| right._values, | ||
| check_dtype=check_dtype, |
There was a problem hiding this comment.
Included this also as it seems it can't be wrong to pass check_dtype here, but not certain of how best to test (if at all)
jreback
requested changes
Aug 17, 2020
| @@ -296,3 +296,10 @@ def test_series_equal_exact_for_nonnumeric(): | |||
| tm.assert_series_equal(s1, s3, check_exact=True) | |||
| with pytest.raises(AssertionError): | |||
| tm.assert_series_equal(s3, s1, check_exact=True) | |||
|
|
|||
|
|
|||
| def test_assert_series_equal_ignore_extension_dtype_mismatch(): | |||
jreback
approved these changes
Aug 17, 2020
|
thanks @dsaxton very nice |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 17, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 17, 2020
…35773) Co-authored-by: Daniel Saxton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff