REF: insert self.on column _after_ concat #35746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
…set-dropped-locs-6
jbrockmendel
commented
Aug 18, 2020
| new_loc = len(df.columns) | ||
| df.insert(new_loc, name, extra_col) | ||
| elif name in df.columns: | ||
| # TODO: sure we want to overwrite results? |
There was a problem hiding this comment.
@mroeschke can you comment on why we do this?
There was a problem hiding this comment.
I haven't really touched _wrap_results much so can't really speak to why we do this. What's an example where this is overwriting results?
There was a problem hiding this comment.
i dont have an example on hand, but can find one bc i know this line is covered by tests. ATM im inclined to not-worry about it
jreback
approved these changes
Aug 19, 2020
mroeschke
approved these changes
Aug 20, 2020
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to push towards #34714 by making _wrap_results do things in the same order as other other similar methods do. cc @mroeschke LMK if there is a simpler way to accomplish this.
Orthogonal to #35470, #35730, #35696.