TST: encoding for URLs in read_csv #35742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jreback merged 1 commit into pandas-dev:master from twoertwein:url_encoding

Aug 17, 2020

Member

twoertwein commented Aug 15, 2020 •

edited

Loading

closes csv_read() fails on properly decoding latin-1(i.e. non utf8) encoded file from URL #10424
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Reading CSVs from URLs with a non UTF-8 encoding should already work.


          TST: encoding for URLs in read_csv

a553a6a

jreback added IO CSV Unicode labels

jreback added this to the 1.2 milestone

jreback merged commit 961b8d4 into pandas-dev:master

Contributor

jreback commented Aug 17, 2020

thanks @twoertwein

twoertwein deleted the url_encoding branch

August 17, 2020 19:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels