REGR: fix DataFrame.diff with read-only data #35707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Algos
doc/source/whatsnew/v1.1.1.rst
Outdated
| @@ -20,6 +20,7 @@ Fixed regressions | |||
| - Fixed regression where :func:`pandas.testing.assert_series_equal` would raise an error when non-numeric dtypes were passed with ``check_exact=True`` (:issue:`35446`) | |||
| - Fixed regression in :class:`pandas.core.groupby.RollingGroupby` where column selection was ignored (:issue:`35486`) | |||
| - Fixed regression in :meth:`DataFrame.shift` with ``axis=1`` and heterogeneous dtypes (:issue:`35488`) | |||
| - Fixed regression in :meth:`DataFrame.diff` with read-only data (:issue:`35559`). | |||
There was a problem hiding this comment.
i think no period at the end, otherwise LGTM
There was a problem hiding this comment.
we are likely inconsistent about this generally, but fixed here.
jreback
approved these changes
Aug 13, 2020
|
@jreback that's what I already did ( |
ahh right, ok then. |
|
Thanks @jorisvandenbossche |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 14, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 14, 2020
) Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35559