ENH: GH-35611 Tests for top-level Pandas functions serializable #35692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 13, 2020
pandas/tests/test_common.py
Outdated
| @@ -157,3 +158,10 @@ def test_version_tag(): | |||
| raise ValueError( | |||
| "No git tags exist, please sync tags between upstream and your repo" | |||
| ) | |||
|
|
|||
|
|
|||
| def test_serializable(): | |||
There was a problem hiding this comment.
can you parameterize the test on these instead or inside
also pls add the issue number here as a comment
There was a problem hiding this comment.
I understand. I'll do that.
There was a problem hiding this comment.
@jreback Could you take a look of this?
jreback
added
IO Pickle
ikedaosushi
force-pushed
the
ENH_GH35611_top-level-serializable
branch
from
8bd86ed to
f8215c4
Compare
jreback
approved these changes
Aug 19, 2020
|
thanks @ikedaosushi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff