BUG: to_pickle/read_pickle do not close user-provided file objects #35686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jreback merged 1 commit into pandas-dev:master from twoertwein:pickle_close

Aug 12, 2020

Member

twoertwein commented Aug 12, 2020

closes BUG: DataFrame.to_pickle(bytes_io_buffer) is automatically closed internally #35679
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Do not close user-provided file-objects in to_pickle and read_pickle.


          BUG: to_pickle/read_pickle do not close user-provided file objects

844bf8d

jreback added Bug IO Data labels

jreback added this to the 1.2 milestone

jreback merged commit a0896e1 into pandas-dev:master

Contributor

jreback commented Aug 12, 2020

thanks @twoertwein very nice!

twoertwein deleted the pickle_close branch

August 12, 2020 22:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels