BUG: Support custom BaseIndexers in groupby.rolling #35647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 10, 2020 08:30
jreback
reviewed
Aug 12, 2020
| @@ -265,7 +265,8 @@ def __init__( | |||
| index_array: Optional[np.ndarray], | |||
| window_size: int, | |||
| groupby_indicies: Dict, | |||
| rolling_indexer: Union[Type[FixedWindowIndexer], Type[VariableWindowIndexer]], | |||
| rolling_indexer: Type[BaseIndexer], | |||
| indexer_kwargs: Optional[Dict], | |||
There was a problem hiding this comment.
why do you need this? (indexer_kwargs)
There was a problem hiding this comment.
In GroupbyRollingIndex I am instantiating th user's custom indexer as I know the index_array from each group,
so I need to do:
UsersIndexer(index_array, window_size, **indexer_kwargs)
|
thanks @mroeschke |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 13, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 13, 2020
…ng (#35699) Co-authored-by: Matthew Roeschke <[email protected]>
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff