-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Make explode work for sets #35637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
impls and tests look fine, the only issue i have is one of ordering. sets are un-ordered, unlike lists and dicst so this could in theory change between runs?
That's true, the order of the output won't be well-defined and could change between runs |
Maybe for the test we just use a set with 1 element so its deterministic, and in the docs we can highlight for sets order is not guaranteed. |
Good catch on updating docs. For the tests I'm thinking we'd want multiple elements to show that it actually expands the result (I could add a singleton set case as well to show that it becomes a scalar)? To deal with non-deterministic order we can sort the output. |
this looks fine, can you merge master and merge on green. |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff