Skip to content

DOC: compression support for file objects in to_csv #35615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2020
Merged

DOC: compression support for file objects in to_csv #35615

merged 1 commit into from
Aug 8, 2020

Conversation

twoertwein
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

I made a mistake in #35129: to_csv supports the compression argument for file objects in binary mode (not for file objects in text/non-binary mode).

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jreback jreback added Docs IO CSV read_csv, to_csv labels Aug 7, 2020
@jreback jreback added this to the 1.2 milestone Aug 7, 2020
@jreback
Copy link
Contributor

jreback commented Aug 7, 2020

thanks @twoertwein ping on green.

@twoertwein
Copy link
Member Author

@jreback ping

@jreback jreback merged commit fa92ece into pandas-dev:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants