Skip to content

BUG: fix styler cell_ids arg so that blank style is ignored on False #35588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 7, 2020
Merged

BUG: fix styler cell_ids arg so that blank style is ignored on False #35588

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72c9982
BUG: fix styler cell_ids arg so that blank style is ignored on False
attack68 Aug 6, 2020
ae39773
BUG: fix styler cell_ids arg so that blank style is ignored on False
attack68 Aug 6, 2020
0489e4f
BUG: fix styler cell_ids arg so that blank style is ignored on False
attack68 Aug 7, 2020
6b8936e
Merge remote-tracking branch 'upstream/master' into styler_arg_bug
simonjayhawkins Aug 7, 2020
2db75df
black fixup
simonjayhawkins Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.1.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Fixed regressions
Bug fixes
~~~~~~~~~

- Bug in ``Styler`` whereby `cell_ids` argument had no effect due to other recent changes (:issue:`35588`).

Categorical
^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion pandas/io/formats/style.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def format_attr(pair):
"is_visible": (c not in hidden_columns),
}
# only add an id if the cell has a style
if self.cell_ids or not (len(ctx[r, c]) == 1 and ctx[r, c][0] == ""):
if self.cell_ids or (r, c) in ctx:
row_dict["id"] = "_".join(cs[1:])
row_es.append(row_dict)
props = []
Expand Down
6 changes: 6 additions & 0 deletions pandas/tests/io/formats/test_style.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1682,6 +1682,12 @@ def f(a, b, styler):
result = styler.pipe((f, "styler"), a=1, b=2)
assert result == (1, 2, styler)

def test_no_cell_ids(self):
# GH 35588
df = pd.DataFrame(data=[[0]])
s = Styler(df, uuid='_', cell_ids=False).render()
assert s.find('<td class="data row0 col0" >') != -1


@td.skip_if_no_mpl
class TestStylerMatplotlibDep:
Expand Down