BUG: to_timedelta fails on Int64 Series with null values #35582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
suggested changes
Aug 6, 2020
|
|
||
| tm.assert_series_equal(result, expected) | ||
|
|
||
| # IntegerArray Series with nulls |
There was a problem hiding this comment.
it looks like other tests for missing values are in
so might want to move this part there
There was a problem hiding this comment.
Alternatively, I would maybe just put this new code in its own test (so a test specifically for passing nullable Int64 dtype data)
|
We'll need a release note. This can go in 1.1.1 I think. |
TomAugspurger
added
Missing-data
jreback
requested changes
Aug 6, 2020
| @@ -166,3 +166,15 @@ def test_to_timedelta_ignore_strings_unit(self): | |||
| arr = np.array([1, 2, "error"], dtype=object) | |||
| result = pd.to_timedelta(arr, unit="ns", errors="ignore") | |||
| tm.assert_numpy_array_equal(result, arr) | |||
|
|
|||
| def test_to_timedelta_nullable_int64_dtype(self): | |||
There was a problem hiding this comment.
can you add the issue number as a comment here
jreback
approved these changes
Aug 7, 2020
|
thanks @egoddard |
|
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 7, 2020
… with null values
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 7, 2020
… values (#35602) Co-authored-by: Eric Goddard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff