Skip to content

Ensure file is closed promptly in case of error #35567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Ensure file is closed promptly in case of error #35567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pandas/io/sas/sasreader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ def read_sas(
if iterator or chunksize:
return reader
Copy link
Contributor

@topper-123 topper-123 Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is potentialy here also, e.g. if the user forgets to wrap his own code in a try/finally.

Could it be an idea to add __enter__ & __exit__ to ReaderBase and rearrange to use with blocks, both here and below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the user does with the Reader object is not pandas' concern ;)
The important thing is not to leave any created objects in an inconsistent state.


data = reader.read()
reader.close()
return data
try:
return reader.read()
finally:
reader.close()