BUG: handle immutable arrays in tz_convert_from_utc (#35530) #35532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
gh35530
branch
3 times, most recently
from
4b09568 to
f60c88f
Compare
|
Seems reasonable; not sure if CI failure was related so restarted |
jbrockmendel
reviewed
Aug 4, 2020
jbrockmendel
reviewed
Aug 4, 2020
|
small comments, otherwise lgtm |
jbrockmendel
reviewed
Aug 4, 2020
pandas/_libs/tslibs/tzconversion.pyx
Outdated
| @@ -457,7 +457,7 @@ cdef int64_t[:] _tz_convert_from_utc(int64_t[:] vals, tzinfo tz): | |||
| str typ | |||
|
|
|||
| if is_utc(tz): | |||
| converted = vals | |||
| return vals | |||
There was a problem hiding this comment.
doesnt need to be this PR, but might be convenient: i think this should probably return a copy, not the original array.
There was a problem hiding this comment.
I agree this should be a copy, can you update @lidavidm otherwise lgtm. pls ping on green.
|
Changed to be a copy (which also lets us remove the const specifiers pointed out), CI green! |
|
LGTM |
WillAyd
approved these changes
Aug 6, 2020
|
Thanks @lidavidm |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff