Added alignable boolean series and its example to .loc docs.
#35506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loc` docs. Fixed formatting
MJafarMashhadi
force-pushed
the
loc_doc_improvement
branch
from
bcfe1ea to
4014a60
Compare
arw2019
reviewed
Aug 2, 2020
There was a problem hiding this comment.
thanks @MJafarMashhadi
A few small comments. Otherwise lgtm
pandas/core/indexing.py
Outdated
| @@ -255,6 +255,8 @@ def loc(self) -> "_LocIndexer": | |||
|
|
|||
| - A boolean array of the same length as the axis being sliced, | |||
| e.g. ``[True, False, True]``. | |||
| - An alignable boolean series. Index of the key will be aligned before | |||
There was a problem hiding this comment.
nit-pick: 'The index of the key'
pandas/core/indexing.py
Outdated
| @@ -264,6 +266,8 @@ def loc(self) -> "_LocIndexer": | |||
| ------ | |||
| KeyError | |||
| If any items are not found. | |||
| IndexingError | |||
| If an indexed key is passed and its index is unalignable to the index. | |||
There was a problem hiding this comment.
nit-pick: 'unalignable to the frame index'
pandas/core/indexing.py
Outdated
| @@ -319,6 +323,13 @@ def loc(self) -> "_LocIndexer": | |||
| max_speed shield | |||
| sidewinder 7 8 | |||
|
|
|||
| Alignable boolean series: | |||
|
Thanks for the review! |
|
Thanks @MJafarMashhadi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI'm just not sure if I needed to add
IndexingErrorto raises section. Added it to be safe, will remove if it's unnecessary.Also, when someone uses
df.loc[df['col'] > 0]it really is the same under the hood,df['col'] > 0is a boolean series with an alignable index. So there might be some overlap?