TST: ensure that DataFrameGroupBy.apply does not convert datetime.date to pd.Timestamp #35504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Apply
|
thanks @smithto1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPreviously, there was a bug in
DataFrameGroupBy.applywhere a column ofdatetime.datewould raise aValueErrorif it was included as column in a multi-column grouping. Somewhere in the grouping the values would be converted topd.Timestampand then when thepd.Timestampcouldn't be found in the index ofdatetime.dates it would throw an error.This bug persisted until 1.0.5 but was fixed in 1.1.0 (not sure which change fixed it). In 1.1.0 the
datetime.dateare not converted topd.Timestamp, so they are treated like any other dtype=object and left unchanged.This PR adds a test to enforce this behaviour to make sure the bug does not arise again.