DOC: add note on str cons to read_sql #35503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

simonjayhawkins merged 1 commit into pandas-dev:master from AdamSpannbauer:master

Aug 1, 2020

Contributor

AdamSpannbauer commented Aug 1, 2020 •

edited

Loading

closes DOC: pd.read_sql() connection disposal for str type connections #35495
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry


          DOC: add note on str cons to read_sql

5386c58

Member

simonjayhawkins commented Aug 1, 2020

simonjayhawkins added the Docs label

simonjayhawkins added this to the 1.2 milestone

arw2019 approved these changes

View reviewed changes

Member

arw2019 left a comment

lgtm

thanks @AdamSpannbauer

simonjayhawkins merged commit 52e815f into pandas-dev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs