Skip to content

MAINT: Fix broadcasting of arrays #35485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented Jul 30, 2020

Prevent empty object arrays from being broadcast

  • closes Numpydev CI Failures #35481
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@bashtage
Copy link
Contributor Author

Probably not the right fix for the future empty array assignment issue, but seems to work.

Prevent empty object arrays from being broadcast
@bashtage bashtage force-pushed the reverse-broadcast branch from 85ca0ff to b439dfc Compare August 2, 2020 23:27
@bashtage bashtage mentioned this pull request Aug 3, 2020
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Aug 3, 2020

@bashtage if this closes #35481, I think tests should be failing (with XPASS), see #35502

@bashtage
Copy link
Contributor Author

bashtage commented Aug 3, 2020

I thought it worked prior to rebase...I'll need to see what happens.

@bashtage bashtage marked this pull request as draft August 3, 2020 14:57
@bashtage
Copy link
Contributor Author

bashtage commented Aug 3, 2020

Definitely not a fix.

@bashtage bashtage closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpydev CI Failures
2 participants