-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
MAINT: Use float arange when required or intended #35477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use float initialization to allow NaN to be set of when setting floating points later. |
Used to be part of #35427, but split it out to have one PR one issue. Required by Future NumPy. |
Ensure arange is float when intened or required by NumPy
b7b03f3
to
2cec488
Compare
Fixes about 12 of the np-dev fails. |
WillAyd
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
simonjayhawkins
approved these changes
Jul 30, 2020
Thanks @bashtage |
@meeseeksdev backport to 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 1, 2020
simonjayhawkins
pushed a commit
that referenced
this pull request
Aug 1, 2020
…#35500) Co-authored-by: Kevin Sheppard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure arange is float when intened or required by NumPy
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff