CLN: clarify TypeError for IndexSlice argument to pd.xs #35411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
force-pushed
the
xs-fails-with-slice
branch
from
8f947ad to
71a63bd
Compare
simonjayhawkins
added
the
Error Reporting
jreback
requested changes
Aug 3, 2020
pandas/core/generic.py
Outdated
| try: | ||
| loc, new_index = self.index.get_loc_level(key, drop_level=drop_level) | ||
| except TypeError: | ||
| raise TypeError(f"Expected label or tuple of labels, got {key}") |
There was a problem hiding this comment.
can you add from e (need to add the the except as well)
jreback
requested changes
Aug 6, 2020
pandas/tests/test_multilevel.py
Outdated
| @@ -1280,6 +1280,26 @@ def test_level_with_tuples(self): | |||
| tm.assert_frame_equal(result, expected) | |||
| tm.assert_frame_equal(result2, expected) | |||
|
|
|||
| def test_xs_with_IndexSlice(self): | |||
| # GH 35301 | |||
There was a problem hiding this comment.
can you move to: pandas/tests/indexing/multiindex/test_xs.py
jreback
added
Indexing
arw2019
force-pushed
the
xs-fails-with-slice
branch
from
90d0f8b to
a2e51bc
Compare
arw2019
force-pushed
the
xs-fails-with-slice
branch
from
a2e51bc to
9ed2654
Compare
jreback
approved these changes
Aug 7, 2020
|
thanks @arw2019 very nice (failure is unrelated) |
|
great! thanks @jreback for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAs per discussion in #35301 we do not support
IndexSlicearguments toxs. This PR aims to clarify theTypeErrorthrown when that happens.I created a separate issue to house the discussion re: functionality of
locvsxs(#35418).