BUG: ValueError: Cannot convert non-finite values (NA or inf) to integer only when DF exceed certain size #35385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for the behavior you are trying to fix? As reviewers that's typically the first thing we look at |
jreback
changed the title
simonjayhawkins
added
Bug
Missing-data
| @@ -1313,7 +1313,7 @@ def check_below_min_count( | |||
| non_nulls = np.prod(shape) | |||
| else: | |||
| non_nulls = mask.size - mask.sum() | |||
| if non_nulls < min_count: | |||
| if non_nulls > 0 and non_nulls < min_count: | |||
|
@ben-arnao can you update here in response to comments? |
|
@TomAugspurger I wasn't sure if this was something people wanted to continue with. I can make the changes @simonjayhawkins suggested if that's what's needed. |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Closing for now. @ben-arnao ping us whenever you'd like to continue and we'll reopen! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff