Skip to content

DOC: Expanded Using a Docker Container section #35379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

DOC: Expanded Using a Docker Container section #35379

merged 1 commit into from
Aug 1, 2020

Conversation

alexhlim
Copy link
Member

Added Docker installation link, Docker commands, and PyCharm sections.

@simonjayhawkins
Copy link
Member

Thanks @alexhlim for the PR. test failure in Windows py37_np18 is unrelated.

INTERNALERROR> assert not 'pandas/tests/base/test_unique.py::test_unique_bad_unicode[idx_or_series_w_bad_unicode0]'

@alexhlim
Copy link
Member Author

Thanks for the reply, @simonjayhawkins! Let me know if there are any revisions I need to do on my end to get these checks passing.

@simonjayhawkins
Copy link
Member

restarted failed job

@alexhlim alexhlim changed the title DOC: Expanded Using a Docker Container section (#35345) DOC: Expanded Using a Docker Container section Jul 22, 2020
@MarcoGorelli MarcoGorelli self-requested a review July 26, 2020 17:30
MarcoGorelli
MarcoGorelli approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexhlim ! I think this makes it more accessible

@alexhlim
Copy link
Member Author

No problem, @MarcoGorelli. Glad I could help!

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Aug 1, 2020
@simonjayhawkins simonjayhawkins merged commit 5223cd1 into pandas-dev:master Aug 1, 2020
@simonjayhawkins
Copy link
Member

Thanks @alexhlim

@alexhlim alexhlim deleted the expand-docker-doc branch August 1, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

DOC: expand "using a Docker container" section
3 participants
@alexhlim @simonjayhawkins @MarcoGorelli