Skip to content

Change defaults for rolling/expanding.apply engine kwargs to None #35374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Change defaults for rolling/expanding.apply engine kwargs to None #35374

merged 2 commits into from
Jul 22, 2020

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Jul 22, 2020 •
edited
Loading

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This change was supposed to be apart of #35182 but was overlooked. Since 1.1 isn't out, this doesn't need to be backported correct?

@mroeschke mroeschke added Enhancement Window rolling, ewma, expanding labels Jul 22, 2020
@jreback jreback added this to the 1.1 milestone Jul 22, 2020
@jreback jreback merged commit 06e2793 into pandas-dev:master Jul 22, 2020
@jreback
Copy link
Contributor

jreback commented Jul 22, 2020

thanks @mroeschke

@mroeschke mroeschke deleted the rolling_apply_engine_default branch July 22, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Window rolling, ewma, expanding
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback