REF: Avoid post-processing in blockwise op #35356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 20, 2020
|
|
||
| no_result = object() | ||
|
|
||
| def cast_result_block(result, block: "Block", how: str) -> "Block": |
There was a problem hiding this comment.
can you put this function elsewhere (module level somewhere) and import, in-line functions make much harder to grok.
There was a problem hiding this comment.
this likely actually belongs as a method on block itself no?
There was a problem hiding this comment.
i dont think this merits a Block method. There will be further refactoring coming up with the goal of having this iteration-over-blocks go through a BlockManager method
There was a problem hiding this comment.
@jreback is this a deal-breaker? id like to postpone this decision until after implementing the BlockManager method that this/apply/ewm eventually call
jreback
added
Groupby
Internals
jreback
approved these changes
Aug 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small step towards #34714
cc @TomAugspurger IIRC you implemented split_frames/split_items, which this removes