REF: remove special casing from Index.equals (always dispatch to subclass) #35330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return other.equals(self) | ||
|
|
||
| if is_extension_array_dtype(other.dtype): | ||
| # All EA-backed Index subclasses override equals |
There was a problem hiding this comment.
can you add a comment about which cases go through here
|
small request, otherwise LGTM |
|
yep lgtm. |
|
ok to merge? |
|
do we have a test for this? |
|
we have tests in pandas\tests\indexes\test_base.py and pandas\tests\indexes\multi\test_equivalence.py and |
|
thanks @simonjayhawkins |
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Dec 18, 2020
… to subclass) (pandas-dev#35330)" This reverts commit 0b90685.
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 18, 2020
… Index.equals (always dispatchto subclass) (pandas-dev#35330)"
simonjayhawkins
added a commit
that referenced
this pull request
Dec 18, 2020
…als (always dispatchto subclass) (#35330)" (#38565) Co-authored-by: Simon Hawkins <[email protected]>
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
… to subclass) (pandas-dev#35330)" (pandas-dev#38560) This reverts commit 0b90685.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.