Skip to content

Update multi.py #35318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update multi.py #35318

wants to merge 2 commits into from

Conversation

zky001
Copy link

@zky001 zky001 commented Jul 17, 2020

fix bugs be metioned on issue #35301

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

fix bugs be metioned on issue pandas-dev#35301
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test for this

Also - are you sure this is enough to fix the original problem? I tried this quickly and it seems like the error persists

fix bugs be metioned on issue pandas-dev#35301
Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I think that does fix the original issue!

Unfortunately as is it seems to break some of the other tests so that's something to look into (in particular a few go wrong in pandas/tests/multi/test_indexing.py)

@zky001
Copy link
Author

zky001 commented Jul 17, 2020

We need a test for this

Also - are you sure this is enough to fix the original problem? I tried this quickly and it seems like the error persists

Cool, I think that does fix the original issue!

Unfortunately as is it seems to break some of the other tests so that's something to look into (in particular a few go wrong in pandas/tests/multi/test_indexing.py)

thanks , I will fix that

@zky001
Copy link
Author

zky001 commented Jul 20, 2020

shall I close this pr? xs is intended for scalar lookups

@jreback
Copy link
Contributor

jreback commented Jul 20, 2020

as indicted in the issue would take a better error message
add a test from the OP

@zky001 zky001 closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants