Skip to content

TST: xfail 32-bit test #35307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

TST: xfail 32-bit test #35307

wants to merge 1 commit into from

Conversation

erfannariman
Copy link
Member

@erfannariman erfannariman commented Jul 16, 2020

ref #35294

@TomAugspurger
Copy link
Contributor

Does that fail for you on a 32-bit system? The second passes for me locally

pandas/tests/window/test_api.py::test_multiple_agg_funcs[rolling-2-expected_vals0] XFAIL                                                              [ 50%]
pandas/tests/window/test_api.py::test_multiple_agg_funcs[expanding-None-expected_vals1] PASSED                                                        [100%]

Also this wouldn't close #35294. To close that we would need to make the code compatible with 32-bit systems.

@erfannariman
Copy link
Member Author

erfannariman commented Jul 16, 2020

Does that fail for you on a 32-bit system? The second passes for me locally

Not sure how to test it locally, I thought I push it and see if it passes the tests.

Also this wouldn't close #35294. To close that we would need to make the code compatible with 32-bit systems.

Yes, my bad, removed the linked issue.

@TomAugspurger
Copy link
Contributor

Our CI isn't set up to handle this yet. You're welcome to give that a shot, but it's not clear how best to do that since 32-bit conda packages aren't readily available.

@erfannariman
Copy link
Member Author

@TomAugspurger so should I close this PR for now, then later maybe open an issue + PR to handle 32-bit failures?

@TomAugspurger
Copy link
Contributor

Yeah, we'll close this.

I don't think we need any new issues though I may be wrong.

@erfannariman erfannariman deleted the 35294-32-bit-failures branch July 17, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants